pkg: disable implicit fallthroughs errors in tinydtls#8367
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Jan 16, 2018
Merged
pkg: disable implicit fallthroughs errors in tinydtls#8367smlng merged 1 commit intoRIOT-OS:masterfrom
smlng merged 1 commit intoRIOT-OS:masterfrom
Conversation
jnohlgard
reviewed
Jan 16, 2018
pkg/tinydtls/Makefile.include
Outdated
|
|
||
| INCLUDES += -I$(PKG_BUILDDIR) | ||
|
|
||
| CFLAGS += -Wno-implicit-fallthrough |
Member
There was a problem hiding this comment.
Doesn't this disable the warnings for all files when USEPKG contains tinydtls?
Member
There was a problem hiding this comment.
Does it work if the CFLAGS are modified in Makefile instead of Makefile.include?
Contributor
There was a problem hiding this comment.
Ups, I overlooked the .include.
Member
Author
There was a problem hiding this comment.
you're right - for both. It also works when putting this into Makefile. But then we should likely move the llvm CFLAGs additions there, too? But in a separate PR, I guess.
kaspar030
requested changes
Jan 16, 2018
Contributor
kaspar030
left a comment
There was a problem hiding this comment.
Please move from Makefile.include to Makefile...
acbfd04 to
2608bc5
Compare
Member
Author
|
done, amended directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Disable
implicit-fallthroughchecks for external package tinydtls, this error is raised with gcc 7.x versions on any platform. Sample error:Issues/PRs references
#8265