slipdev: wait a few instructions on receive#8258
Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
slipdev: wait a few instructions on receive#8258miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Member
|
Is the ring buffer implementation faulty? |
Member
Author
|
Might be. What I saw indicated that the packet might become out of alignment... But I was thinking about redo-ing the slipdev driver in a more ISR-safe way on the train-ride I did while opening this PR (will do that tomorrow). |
Member
Author
|
I think #8268 is a way cleaner approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Wait a tiny bit before fetching on
slipdevthe received data from the device. This fixes #8003 for me, but definitely goes into the arcane magic direction ;-).Issues/PRs references
Fixes #8003