docheck: make doccheck executable from any directory#8220
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Dec 18, 2017
Merged
docheck: make doccheck executable from any directory#8220miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
The doccheck script reports reports a false positive when executed from any directory but `RIOTBASE`. With this fix, `make doc` changes into the currently unused `RIOTBASE` variable. This is an alternative approach to RIOT-OS#7217, which removes this variable, but keeps the false positive aspect of the script untouched.
Member
Author
smlng
approved these changes
Dec 18, 2017
Member
smlng
left a comment
There was a problem hiding this comment.
DUPACK, tested and works as expected. Also like it better than the alternative, lets do this!
Member
do >10 days satisfy this condition already 😉 |
Member
Author
|
Yepp, especially since I already notified @OlegHahm offline ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doccheck script reports reports a false positive when executed from
any directory but
RIOTBASE. With this fix,make docchanges intothe currently unused
RIOTBASEvariable.This is an alternative approach to #7217, which removes this variable,
but keeps the false positive aspect of the script untouched.