dist: add commit message length checker#8202
Conversation
|
Why is Travis not executing that script? |
|
Mh... if I run |
(I was mistaken with that assessment... I'm just confused, why it doesn't work, while it works locally for me) |
|
Ahh... could it be, that the empty commits are removed by this (the rebase)? |
|
Works now with a non-empty commit! :-) |
|
How does it work with multiline commit messages ? Maybe we want to keep those ones ? |
As long as contributors stick to the rules for those (i.e. start the detailed description after one empty line after the summary) the check will only complain about the summary ( |
|
As you can see in https://travis-ci.org/RIOT-OS/RIOT/builds/311342120: 79cfa95 doesn't show up, but d268896 still does. |
aabadie
left a comment
There was a problem hiding this comment.
The copyright needs to be updated. I find the test script a bit difficult to read but maybe because I'm missing experience on shell scripts.
dist/tools/commit-msg/check.sh
Outdated
| @@ -0,0 +1,48 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Copyright 2015 Oliver Hahm <oliver.hahm@inria.fr> | |||
There was a problem hiding this comment.
Is this the right copyright ?
|
I like 👍 |
|
Ping? |
aabadie
left a comment
There was a problem hiding this comment.
No particular comments on the check scripts and it seems to work on CIs, so ACK
Please remove the wrong commits and extra file, then squash.
14aacd0 to
83930a0
Compare
|
Done. Did a minor indentation fix to the script ;-) |
|
All green, go! |
|
I'm not sure I like this... all my commit descriptions are longer than 50 characters... ;) |
Well it is BCP for git, so you better should adapt your git behavior ;-). Also: those only get a warning, the 72 ones are the ones that cause errors ;-). |
This checks if the commit messages of a PR follow the 50/72 rule. This way we don't merge these kind of commit messages accidentally anymore ;-).