Skip to content

net/ipv6/hdr: fix issue #5944#7957

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
PeterKietzmann:pr_ipv6_hdr_fix
Nov 10, 2017
Merged

net/ipv6/hdr: fix issue #5944#7957
miri64 merged 1 commit intoRIOT-OS:masterfrom
PeterKietzmann:pr_ipv6_hdr_fix

Conversation

@PeterKietzmann
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann commented Nov 8, 2017

Quick attempt to fix #5944

@PeterKietzmann PeterKietzmann added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Nov 8, 2017
@PeterKietzmann PeterKietzmann requested a review from miri64 November 8, 2017 09:43
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 8, 2017

I'll try to get my hands on a MSP430 platform tomorrow to test.

miri64
miri64 approved these changes Nov 10, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on z1 and fixes #5944.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 10, 2017
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Nov 10, 2017

Please state what was wrong and how it is fixed...

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 10, 2017

The test failed on MSP430:

2017-11-10 10:49:03,980 - INFO # RIOT MSP430 hardware initialization complete.
2017-11-10 10:49:03,980 - INFO # 
2017-11-10 10:49:03,980 - INFO # main(): This is RIOT! (Version: 2018.01-devel-360-gd689a-sarajevo)
2017-11-10 10:49:03,994 - INFO # .............
2017-11-10 10:49:03,998 - INFO # ipv6_hdr_tests.test_ipv6_hdr_inet_csum__initial_sum_overflows (tests/unittests/tests-ipv6_hdr/tests-ipv6_hdr.c 266) exp 5961 was 5962
2017-11-10 10:49:03,998 - INFO # .
2017-11-10 10:49:04,001 - INFO # run 14 failures 1

It is fixed by upcasting the uint16_t so the integer overflow is handled correctly.

@miri64 miri64 merged commit d2ccbc8 into RIOT-OS:master Nov 10, 2017
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
@PeterKietzmann PeterKietzmann deleted the pr_ipv6_hdr_fix branch March 4, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2018.01

Development

Successfully merging this pull request may close these issues.

msp430: ipv6_hdr unittests fail

4 participants

@PeterKietzmann @miri64 @kaspar030 @aabadie