examples: only whitelist a few essential boards (dirty hack)#7953
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Nov 7, 2017
Merged
examples: only whitelist a few essential boards (dirty hack)#7953miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
This is a dirty hack proposed by @kaspar030 offline (with slight adaptations) to allow Murdock to build properly tonight. @kaspar030 revert if the issue is fixed, @miri64 close this one if it isn't merged tonight. Right now Murdock fails randomly for some boards, because it doesn't has the `xxd` tool installed.
a265997 to
2fbd228
Compare
cladmi
approved these changes
Nov 7, 2017
Contributor
cladmi
left a comment
There was a problem hiding this comment.
ACK, should be merged quickly or useless for Hack'n'Hack.
Member
Author
|
(the problem is that @kaspar030 did some maintenance work and missed some machines and doesn't have access to them right now. This is a very temporary fix that should be properly resolved by tomorrow). |
Contributor
|
actually, xxd is needed for all boards (including native and samr21) thus will only make a false negative more unlikely... |
Member
Author
|
I didn't want to deactivate all the boards that's why I kept our two "reference" platforms. Until now it seems to work. |
Contributor
|
The problem is resolved. Should we just press revert in this PR? |
Member
Author
|
I guess that is the cleanest approach |
Member
Author
|
See #7987 for reresal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a dirty hack proposed by @kaspar030 offline (with slight adaptations) to allow Murdock to build properly tonight. @kaspar030 revert if the issue is fixed, @miri64 close this one if it isn't merged tonight.