Skip to content

drivers/nrf24l01p: misc fixed#7855

Merged
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
kYc0o:fix_nrf24l01p_var_sizes
Nov 9, 2017
Merged

drivers/nrf24l01p: misc fixed#7855
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
kYc0o:fix_nrf24l01p_var_sizes

Conversation

@kYc0o
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o commented Oct 26, 2017

While compiling tests/driver_nrf24l01p_lowlevel with clang in OS X it discovers several minor issues.

This PR fixes them.

@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tests Area: tests and testing framework labels Oct 26, 2017
aabadie
aabadie reviewed Oct 26, 2017
View reviewed changes
drivers/include/nrf24l01p.h Outdated
gpio_t ce; /**< GPIO pin to initialize as chip enable */
gpio_t cs; /**< GPIO pin to initialize as chip select */
gpio_t irq; /**< GPIO pin to initialize as interrupt request */
unsigned int listener; /**< Place to store an ID in */
Copy link
Copy Markdown
Contributor

@aabadie aabadie Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can unsigned be enough ?

Copy link
Copy Markdown
Contributor Author

@kYc0o kYc0o Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, will try.

Copy link
Copy Markdown
Contributor Author

@kYc0o kYc0o Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned also does the trick. Changed.

@kYc0o kYc0o mentioned this pull request Oct 26, 2017
Closed
16 tasks
@kYc0o
Copy link
Copy Markdown
Contributor Author

kYc0o commented Oct 31, 2017

@aabadie I addressed your comment. Can I squash?

@kYc0o
Copy link
Copy Markdown
Contributor Author

kYc0o commented Nov 7, 2017

Ping!

@kYc0o
Copy link
Copy Markdown
Contributor Author

kYc0o commented Nov 7, 2017

ping6!

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 8, 2017

Please squash. One, max two commits should be enough

@kYc0o kYc0o force-pushed the fix_nrf24l01p_var_sizes branch from 55d9aa7 to aad3c25 Compare November 8, 2017 19:10
@kYc0o
Copy link
Copy Markdown
Contributor Author

kYc0o commented Nov 8, 2017

Squashed.

PeterKietzmann
PeterKietzmann approved these changes Nov 9, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit 87b0477 into RIOT-OS:master Nov 9, 2017
@kYc0o kYc0o deleted the fix_nrf24l01p_var_sizes branch November 9, 2017 12:43
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie left review comments

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees

@haukepetersen haukepetersen

Labels

Area: drivers Area: Device drivers Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2018.01

Development

Successfully merging this pull request may close these issues.

4 participants

@kYc0o @PeterKietzmann @aabadie @haukepetersen