Skip to content

sys/can: fix building errors on native OS X#7847

Merged
vincent-d merged 2 commits intoRIOT-OS:masterfrom
kYc0o:fix_can_osx
Oct 25, 2017
Merged

sys/can: fix building errors on native OS X#7847
vincent-d merged 2 commits intoRIOT-OS:masterfrom
kYc0o:fix_can_osx

Conversation

@kYc0o
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o commented Oct 25, 2017

Building tests/conn_can lead to the following error(s):

/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:91:23: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    for (int i = 0; i < CAN_DLL_NUMOF; i++) {
                    ~ ^ ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:112:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:143:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:206:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:347:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:411:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:454:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
/Users/facosta/git/RIOT-OS/RIOT/tests/conn_can/main.c:477:15: error: comparison of integers of different signs: 'int' and 'unsigned int'
      [-Werror,-Wsign-compare]
    if (ifnum >= CAN_DLL_NUMOF) {
        ~~~~~ ^  ~~~~~~~~~~~~~
8 errors generated.

This PR fix those errors, plus another error about unused function _can_event_error_to_msg.

@vincent-d I didn't find any usage in the whole RIOT basecode of the function _can_event_error_to_msg thus I removed it. Can you check if it's correct?

@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2017
@kYc0o kYc0o added this to the Release 2017.10 milestone Oct 25, 2017
@kYc0o kYc0o requested a review from vincent-d October 25, 2017 14:47
@kYc0o kYc0o mentioned this pull request Oct 25, 2017
Closed
7 tasks
vincent-d
vincent-d approved these changes Oct 25, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ACK

@vincent-d
Copy link
Copy Markdown
Member

vincent-d commented Oct 25, 2017

All green, go

@vincent-d vincent-d merged commit 2252acf into RIOT-OS:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincent-d vincent-d vincent-d approved these changes

Assignees

@vincent-d vincent-d

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2017.10

Development

Successfully merging this pull request may close these issues.

2 participants

@kYc0o @vincent-d