tests/ssp: Fix on macOS while compiling w/ clang#7777
Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom Oct 31, 2017
Merged
tests/ssp: Fix on macOS while compiling w/ clang#7777jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
Conversation
jnohlgard
approved these changes
Oct 20, 2017
Member
jnohlgard
left a comment
There was a problem hiding this comment.
Looks fine, except for the comment style. I wonder how long it will be until an improved bounds check in clang catches this workaround 😊
tests/ssp/main.c
Outdated
| { | ||
| char buf[16]; | ||
|
|
||
| // clang will detect the buffer overflow |
Member
There was a problem hiding this comment.
Change this to c style comment
7 tasks
On macOS using Apple LLVM version 9.0.0 this test would not compile due to clang detecting the buffer overflow. Since this test is all about having a buffer overflow, I tricked clang into not detecting this anymore. This loosely relates to #6473.
dd8fd10 to
4710701
Compare
Contributor
Author
|
Comment style changed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS using Apple LLVM version 9.0.0 this test would
not compile due to clang detecting the buffer overflow.
Since this test is all about having a buffer overflow, I
tricked clang into not detecting this anymore.
This loosely relates to #6473.