Skip to content

cpu/stm32f4: optimized isr vector definitions#7678

Merged
vincent-d merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:opt_stm32f4_isrvectors
Oct 9, 2017
Merged

cpu/stm32f4: optimized isr vector definitions#7678
vincent-d merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:opt_stm32f4_isrvectors

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

follow up on #7535

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 6, 2017
@haukepetersen haukepetersen added this to the Release 2017.10 milestone Oct 6, 2017
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR, much cleaner initializers when the reserved vectors are skipped.
Do the our of sequence array initializers work for all versions of gcc? Clang?

@haukepetersen haukepetersen force-pushed the opt_stm32f4_isrvectors branch from a942137 to 73de523 Compare October 6, 2017 14:37
@haukepetersen
Copy link
Copy Markdown
Contributor Author

as far as I know yes.

Copy link
Copy Markdown
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@vincent-d
Copy link
Copy Markdown
Member

And go

@vincent-d vincent-d merged commit 802ed40 into RIOT-OS:master Oct 9, 2017
@haukepetersen haukepetersen deleted the opt_stm32f4_isrvectors branch October 9, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants