cpu/stm32_common: fix PLLs enabling and usage#7537
Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom Sep 1, 2017
Merged
Conversation
Member
Author
|
Found another bug with extra PLL enabling, fixed it. |
aabadie
requested changes
Aug 31, 2017
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Looks good, just a minor style thing.
cpu/stm32_common/stmclk.c
Outdated
| #endif | ||
|
|
||
| #if defined(CPU_FAM_STM32F2) | ||
| #define RCC_PLLCFGR_PLLP_Pos (16U) |
Contributor
There was a problem hiding this comment.
Small nit: the defines could be aligned with the ones below
Member
Author
There was a problem hiding this comment.
Fixed and amended directly
a8f3d2f to
4ce117f
Compare
Contributor
|
Needs rebase here |
4ce117f to
05c7311
Compare
Member
Author
|
Rebased |
aabadie
approved these changes
Sep 1, 2017
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Tested nucleo144-f207, still works (well, the shell and gpio worked).
ACK
Contributor
|
and go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow up of #7477. I I realized I needed R factor for PLL I2S on stm32f2 to use as MCO2.
So this add possibility to use R output for every PLL.