Skip to content

at86rf2xx: fix channel asserts#7488

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
miri64:at86rf2xx/fix/assert-chan
Nov 16, 2017
Merged

at86rf2xx: fix channel asserts#7488
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
miri64:at86rf2xx/fix/assert-chan

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 21, 2017

Alternative to #7427, just fixes the assert to the specified type in netopt.h.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers Area: network Area: Networking labels Aug 21, 2017
@miri64 miri64 requested a review from thomaseichinger August 21, 2017 10:16
haukepetersen
haukepetersen previously approved these changes Aug 29, 2017
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 29, 2017
@miri64 miri64 force-pushed the at86rf2xx/fix/assert-chan branch from 52d75ad to e0319ed Compare September 20, 2017 15:24
@miri64 miri64 dismissed haukepetersen’s stale review September 20, 2017 15:24

Rebased to current master (was a little bit complicated). Please re-ACK.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Oct 3, 2017

What was the rationale for 8 bit wide channels again?

Btw: the rationale for my proposed PR was that packages that access this netdev option may often use uint8_t for channel numbers (which seems to be a reasonable size). Of course, one could extend this to uint16_t in the adaptation layer or a patch file, but somehow this feels wrong.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 3, 2017

What was the rationale for 8 bit wide channels again?

Did you mean 16-bit wide? If not: You proposed to change the type in #7427, so you have to answer that. If yes: I think @haukepetersen aimed for simplicity in API usage, so all scalar numbers were either int16_t or uint16_t when he started NETOPT.

Btw: the rationale for my proposed PR was that packages that access this netdev option may often use uint8_t for channel numbers (which seems to be a reasonable size). Of course, one could extend this to uint16_t in the adaptation layer or a patch file, but somehow this feels wrong.

But your proposed PR was an API change in disguise (handing over uint16_t after your PR to get/set would potentially break the behaviour + it didn't even change it for all devices), that's the main reason why I was against that PR and opted for this solution.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Oct 3, 2017

Yes, I mean 16 bit. And yes I agree that my PR is broken. Let's see if we can find a better solution.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 4, 2017

In the meantime, let's fix the bug and merge this PR?

@miri64 miri64 force-pushed the at86rf2xx/fix/assert-chan branch from e0319ed to bae9c2e Compare November 15, 2017 17:45
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 15, 2017

Rebased to current master.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 15, 2017

@haukepetersen could you maybe re-ACK? You ACK'd already on Aug 29.

Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit 3ced935 into RIOT-OS:master Nov 16, 2017
@miri64 miri64 deleted the at86rf2xx/fix/assert-chan branch November 16, 2017 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants