Skip to content

cpu/stm32f4: implement stmclk interface for stm32f4#7158

Merged
aabadie merged 3 commits intoRIOT-OS:masterfrom
OTAkeys:pr/stmclk_f4
Jun 15, 2017
Merged

cpu/stm32f4: implement stmclk interface for stm32f4#7158
aabadie merged 3 commits intoRIOT-OS:masterfrom
OTAkeys:pr/stmclk_f4

Conversation

@vincent-d
Copy link
Copy Markdown
Member

@vincent-d vincent-d commented Jun 8, 2017

This implement stmclk for stm32f4 (#7123). Mainly copied and adapted from stm32f7.

I had to update a lot of vendor headers, as well as main clock speed for some boards.

Tested on nucleo-f401 and nucleo144-f413 (example/default compile and run). I'm not sure of every board config regarding LSE, though.

@vincent-d vincent-d added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 8, 2017
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 8, 2017 •
edited
Loading

I can test on the other boards I have here:

  • nucleo-f410
  • nucleo-f411
  • nucleo-f446
  • nucleo144-f446
  • nucleo144-f429

@aabadie aabadie added this to the Release 2017.07 milestone Jun 8, 2017
@vincent-d vincent-d mentioned this pull request Jun 8, 2017
Merged
@vincent-d vincent-d changed the title cpu/stm32f4: implements stmclk interface for stm32f4 cpu/stm32f4: implement stmclk interface for stm32f4 Jun 8, 2017
@haukepetersen haukepetersen mentioned this pull request Jun 8, 2017
Closed
9 tasks
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 14, 2017

I'll be with the boards tomorrow so I can test !

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 15, 2017

I didn't test nucleo144-f446 but the other f4 I have worked.

I have a question: why did you have to update the CMSIS files ?

@vincent-d
Copy link
Copy Markdown
Member Author

vincent-d commented Jun 15, 2017

I have a question: why did you have to update the CMSIS files ?

Some defines like RCC_CFGR_SWS_Msk were added in between by ST. They were present in the last CMSIS file we added, but not in the oldests.

aabadie
aabadie approved these changes Jun 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good here. ACK

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 15, 2017

and go!

@aabadie aabadie merged commit 9dadb9c into RIOT-OS:master Jun 15, 2017
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 15, 2017

Thanks @vincent-d !

@vincent-d vincent-d deleted the pr/stmclk_f4 branch June 16, 2017 12:47
@aabadie aabadie mentioned this pull request Jun 23, 2017
Merged
@smlng smlng mentioned this pull request Jul 13, 2017
Closed
@kYc0o kYc0o mentioned this pull request Jan 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

@haukepetersen haukepetersen

@aabadie aabadie

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.07

Development

Successfully merging this pull request may close these issues.

3 participants

@vincent-d @aabadie @haukepetersen