frdm-k64f: Move clock initialization to board_init#6986
frdm-k64f: Move clock initialization to board_init#6986jnohlgard wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
1ef9a26 to
7b160e9
Compare
|
Ping @haukepetersen |
haukepetersen
left a comment
There was a problem hiding this comment.
So if I understand this correctly, the situation here is that we clock the system through a clock signal that is applied to pin PA19 instead of some XTAL or similar source, right?
So IMHO the changes look valid, I have only a simple style request: I would prefer to get rid of the cpu_clock_init (also as the prefix does not fit the module here), and rather paste the containing lines directly into the board_init function to keep things straight forward...
|
I agree with @haukepetersen here. ACK when the changes are applied. |
7b160e9 to
f64f97d
Compare
|
@haukepetersen @kYc0o ping |
The clock setting on this board depends on the existence of an external RMII crystal, which is not mandatory for the CPU itself.
f64f97d to
d3d7b1d
Compare
|
I think this one only needs an ACK. @haukepetersen |
|
Let's postpone this. I want to move cpu.c to kinetis_common and improve the configurability of the clock initialization code to remove the need to configure clocks in board_init. |
|
Are you sure you want to close @gebart ? |
|
@aabadie yes, we will save lots of code duplication by going with a shared cpu_init for all Kinetis CPUs. There's only some small improvements needed in the configuration to allow it. |
The clock setting on this board depends on the existence of an external RMII crystal, which is not mandatory for the CPU itself.
The clock settings in general should be deferred to board_init IMO, there are so many different settings possible that it makes no sense to default the CPU into any particular mode other than the hardware defaults.