Skip to content

net: remove conn API#6976

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
miri64:conn/cleanup/rm
May 12, 2017
Merged

net: remove conn API#6976
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
miri64:conn/cleanup/rm

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Apr 26, 2017

conn was deprecated in 3821734. 3 Releases later and now that no module
is using it RIOT-internally anymore, I think it is time to say goodbye.

Requires #6974 to pass all tests.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: network Area: Networking labels Apr 26, 2017
@miri64 miri64 added this to the Release 2017.07 milestone Apr 26, 2017
@miri64 miri64 requested review from cgundogan, kaspar030 and smlng April 26, 2017 13:23
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Apr 26, 2017

 miri64 assigned cgundogan, emmanuelsearch, kaspar030, and smlng 24 minutes ago
> miri64 requested review from cgundogan, kaspar030, and smlng 24 minutes ago

We need a "request review from everyone, assign all" button!

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 26, 2017

assignment of multiple people in my case doesn't mean I want all their opinions, just one of them ;-). Those not interested to review can always remove their assignment ;-)

@miri64 miri64 mentioned this pull request Apr 27, 2017
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 27, 2017

Rebased to current master.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 27, 2017
smlng
smlng suggested changes Apr 28, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed/removed some more legacy conn stuff I found see: miri64#30

makefiles/pseudomodules.inc.mk Outdated
@@ -1,8 +1,5 @@
PSEUDOMODULES += auto_init_gnrc_rpl
PSEUDOMODULES += conn
Copy link
Copy Markdown
Member

@smlng smlng Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be remove to?

pkg/emb6/patches/0004-Provide-event-type-for-RIOT-s-conn_.-_send.patch Outdated
#define EVENT_TYPE_TCPIP 0x06 ///< New tcpip event
#define EVENT_TYPE_SLIP_POLL 0x07 ///< Process slip handler
+#define EVENT_TYPE_CONN_SEND 0x08 ///< Send command from conn layer
+#define EVENT_TYPE_CONN_SEND 0x08 ///< Send command from sock layer
Copy link
Copy Markdown
Member

@smlng smlng Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't EVENT_TYPE_SOCK_SEND be more appropriate, though it requires to change every usage of this macro, too.

Copy link
Copy Markdown
Member

@smlng smlng Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in miri64#30

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 28, 2017

oops merged

@smlng smlng added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 28, 2017
@smlng
Copy link
Copy Markdown
Member

smlng commented Apr 28, 2017

@miri64 please squash (including my small additions)

@smlng
Copy link
Copy Markdown
Member

smlng commented Apr 28, 2017

and make the merge commit disappear 😉

@miri64
net: remove conn API
1377036 
conn was deprecated in 3821734. 3 Releases later and now that no module
is using it RIOT-internally anymore, I think it is time to say goodbye.
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 28, 2017

Done

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 28, 2017
@smlng
Copy link
Copy Markdown
Member

smlng commented Apr 28, 2017

a second review and approval would be great!

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 28, 2017

@kaspar030 @emmanuelsearch @cgundogan?

@smlng
Copy link
Copy Markdown
Member

smlng commented May 12, 2017

ping, anyone willing to ACK, too?

@miri64 miri64 added the Impact: major The PR changes a significant part of the code base. It should be reviewed carefully label May 12, 2017
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented May 12, 2017

Let's go!

@kaspar030 kaspar030 merged commit f5a4124 into RIOT-OS:master May 12, 2017
@smlng
Copy link
Copy Markdown
Member

smlng commented May 12, 2017

🎉 finally!

@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented May 12, 2017

yes!

@miri64 miri64 deleted the conn/cleanup/rm branch May 12, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgundogan cgundogan Awaiting requested review from cgundogan

@kaspar030 kaspar030 Awaiting requested review from kaspar030

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cgundogan cgundogan

@emmanuelsearch emmanuelsearch

@kaspar030 kaspar030

@smlng smlng

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.07

Development

Successfully merging this pull request may close these issues.

5 participants

@miri64 @kaspar030 @smlng @emmanuelsearch @cgundogan