examples/gnrc_{minimal,networking}: simplify XBee setup#6971
Closed
aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
examples/gnrc_{minimal,networking}: simplify XBee setup#6971aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
|
Actually, I would give this PR another direction and remove all the xbee specific lines from the makefile(s) alltogether! There is no need to define the UART_DEV(1) for the xbee device, as this is the default parameter in -> see #6982 |
Contributor
Author
|
I also thought the same but the thing is that keeping those lines shows new users how to deal with Xbee and the networking examples. |
Contributor
Author
|
closing in favor #6982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to simplify the configuration of an XBee with networking examples. The idea is to apply the XBee UART flag only when xbee module is loaded.
As a consequence, one can simply build a networking firmware using a XBee with the following command:
If you think this PR is worth, it can also be applied to other networking examples: emcute, microcoap, nanocoap, gcoap, dtls ?