can: add tja1042 transceiver driver#6925
Merged
vincent-d merged 2 commits intoRIOT-OS:masterfrom Jan 18, 2018
Merged
Conversation
42598a7 to
2f6dddf
Compare
Member
Author
|
Rebased and updated, added an extra test app. Still need to re-test it. |
smlng
suggested changes
Jan 15, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
mainly doxygen related, hence update docu to common usage in RIOT (see other drivers for grouping, for instance).
drivers/include/tja1042.h
Outdated
| */ | ||
|
|
||
| /** | ||
| * @defgroup tja1042 TJA1042 |
|
|
||
| /** | ||
| * @defgroup tja1042 TJA1042 | ||
| * @ingroup trx_can |
Member
There was a problem hiding this comment.
multiple groups are possible, add @ingroup drivers here, too
drivers/include/tja1042.h
Outdated
| #endif | ||
|
|
||
| /** | ||
| * tja1042 can trx descriptor |
tests/can_trx/Makefile
Outdated
| include ../Makefile.tests_common | ||
|
|
||
|
|
||
| CFLAGS += -DDEVELHELP |
Member
There was a problem hiding this comment.
can be removed, set in tests_common
Member
Author
|
@smlng comments addressed |
smlng
suggested changes
Jan 17, 2018
drivers/tja1042/tja1042.c
Outdated
| */ | ||
|
|
||
| /** | ||
| * @ingroup tja1042 trx |
Member
There was a problem hiding this comment.
should be @ingroup drivers_tja1042 only
Member
There was a problem hiding this comment.
though also these files are not parsed by doxygen, anyway.
Member
|
looks good, please squash. |
smlng
approved these changes
Jan 17, 2018
Member
Author
|
All green, go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up, based on #5793
This is the TJA1042 (http://www.nxp.com/documents/data_sheet/TJA1042.pdf) HS CAN transceiver driver.