Skip to content

llvm: Fall back for missing objcopy#6673

Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/llvm-objcopy
Mar 13, 2017
Merged

llvm: Fall back for missing objcopy#6673
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/llvm-objcopy

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

Copied from Makefile.include.gnu

Copied from Makefile.include.gnu
@jnohlgard jnohlgard added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: build system Area: Build system labels Mar 1, 2017
@jnohlgard jnohlgard added this to the Release 2017.04 milestone Mar 1, 2017
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2017
@kYc0o kYc0o mentioned this pull request Mar 3, 2017
@jnohlgard
Copy link
Copy Markdown
Member Author

This should be a quick and easy review, any takers? @OlegHahm @kaspar030

Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

# objcopy does not have a clear substitute in LLVM, use GNU binutils
#export OBJCOPY = $(LLVMPREFIX)objcopy
export OBJCOPY = $(PREFIX)objcopy
export OBJCOPY ?= $(shell command -v $(PREFIX)objcopy gobjcopy objcopy | head -n 1)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the indent is (and was) off. Fix if you feel like.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above is off indent because of the comment prefix.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sorry!

@jnohlgard jnohlgard merged commit ba2689b into RIOT-OS:master Mar 13, 2017
@jnohlgard jnohlgard deleted the pr/llvm-objcopy branch March 24, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants