newlib: Split newlib into one generic part and one default syscalls part#6670
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jun 1, 2017
Merged
Conversation
2003f2e to
8c6b19c
Compare
kaspar030
reviewed
Mar 15, 2017
|
|
||
| ifneq (,$(filter newlib_syscalls_default,$(USEMODULE))) | ||
| include $(RIOTBASE)/sys/newlib/Makefile.include | ||
| include $(RIOTBASE)/sys/newlib_syscalls_default/Makefile.include |
Contributor
There was a problem hiding this comment.
how about moving this into a subfolder of newlib?
Member
Author
There was a problem hiding this comment.
the newlib subfolder is gone. Makefile.newlib is the place for newlib settings.
Member
Author
There was a problem hiding this comment.
which I hope we can move to makefiles/newlib.mk or something in a separate PR.
Member
Author
|
8c6b19c to
b0f62af
Compare
Member
Author
|
rebased on #4699 as an experiment |
b0f62af to
0ddd2ef
Compare
0ddd2ef to
b81b666
Compare
Member
Author
|
rebased after #4699 was merged |
Member
Author
|
@kaspar030 ping |
Contributor
|
ACK from me |
neiljay
approved these changes
Jun 1, 2017
Member
|
@gebart the last Murdock build is pre-release (and Jenkins and Murdock were still activaded). Would you be so kind to rebase. |
Contributor
|
Just triggering murdock is enough to build-test a merge into current master. |
Member
|
Oh right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the contents of sys/newlib into one part for the default syscall implementation, and one part for setting up the build environment for building with newlib, regardless of what syscall implementation is used.
This will help some of the MIPS ports which have their own semihosting newlib environment with a syscall implementation.