Skip to content

gnrc_mac: add support for multicast pkt.#6627

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
zhuoshuguo:add_support_for_multicast_for_gnrc_mac
Mar 14, 2017
Merged

gnrc_mac: add support for multicast pkt.#6627
miri64 merged 1 commit intoRIOT-OS:masterfrom
zhuoshuguo:add_support_for_multicast_for_gnrc_mac

Conversation

@zhuoshuguo
Copy link
Copy Markdown
Contributor

This PR adds support for multicast packets when they are pushed to MAC layer's TX queue. (when using gnrc_mac module).

@zhuoshuguo zhuoshuguo force-pushed the add_support_for_multicast_for_gnrc_mac branch from c911c5d to 07bd84c Compare February 18, 2017 12:15
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Mar 3, 2017

Can you provide a test case?

@kYc0o kYc0o added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation GNRC Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 3, 2017
@kYc0o kYc0o added this to the Release 2017.04 milestone Mar 3, 2017
@zhuoshuguo
Copy link
Copy Markdown
Contributor Author

Sure, in unitest?

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Mar 3, 2017

Maybe you can extend tests-gnrc_mac_internal? Also, just give a hint on how to test this PR.

@zhuoshuguo
Copy link
Copy Markdown
Contributor Author

Yes, good idea. :-)

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go (if you want to provide tests, please do in a follow-up, but I'm fine with the change as is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants