Skip to content

pkg/relic: add patch, fix missing new line#6609

Closed
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/relic/add_patch
Closed

pkg/relic: add patch, fix missing new line#6609
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/relic/add_patch

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Feb 15, 2017

required for #6600

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports labels Feb 15, 2017
@smlng smlng self-assigned this Feb 15, 2017
@smlng smlng mentioned this pull request Feb 15, 2017
Closed
@smlng smlng requested a review from tfar February 15, 2017 14:22
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 15, 2017
@smlng smlng added this to the Release 2017.04 milestone Feb 15, 2017
tfar
tfar approved these changes Feb 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@tfar tfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Could be upstreamed if the issue is also in the relic repo.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 15, 2017

@tfar I think its from the upstream, but if this is fixed upstream we need to update the package in RIOT (with patches and so on) <- if you could/would take of that?!

@tfar
Copy link
Copy Markdown
Contributor

tfar commented Feb 15, 2017

Can take a look at that next weekend.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 16, 2017

@tfar maybe you can create a riot branch in your fork that has all the required changes in it, and we can use the latest commit of that branch in the RIOT relic package. This would also help to simplify future update of the package, as you can rebase on upstream master and adapt + we don't need to patch in RIOT. What do you think?

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 16, 2017

@OlegHahm can you've a look and approve, its only minor but needed to get llvm working, see #6600. Hopefully @tfar can update the package in general soonish, but until then I'd like to get llvm finished and enabled in Jenkins.

@smlng smlng added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 17, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 23, 2017

ping! @tfar: any news on patching this upstream and update package version in RIOT?

@kaspar030 kaspar030 modified the milestone: Release 2017.04 Apr 21, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented May 12, 2017

closing in favor of #6965 ...

@smlng smlng closed this May 12, 2017
@smlng smlng deleted the pr/pkg/relic/add_patch branch July 5, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tfar tfar tfar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smlng smlng

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlng @tfar @kaspar030