Merged
Conversation
smlng
reviewed
Feb 15, 2017
|
|
||
| # Newlib includes should go after GCC includes. | ||
| export INCLUDES += $(NEWLIB_INCLUDES) | ||
| export INCLUDES := $(NEWLIB_INCLUDES) $(INCLUDES) |
Member
There was a problem hiding this comment.
the comment above says, that order should be reversed? So either correct here or the comment, and explain w reasoning for certain order.
Member
There was a problem hiding this comment.
just (re)read your description and you want to have newlib before other includes, hence please adapt comment
Member
Author
|
Will update the comment later. No time right now.
…On Feb 16, 2017 9:07 AM, "Sebastian Meiling" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please fix comment as suggested, otherwise ACK. Is needed to get LLVM
toolchain support, see #6600 <#6600>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6606 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AATYQrHX7kkS7hzkvqnla-RWR3AiNsFIks5rdAPMgaJpZM4MA6VS>
.
|
added 2 commits
February 16, 2017 16:28
native should only use the compiler defaults for system includes.
320ed96 to
9830912
Compare
Member
Author
|
Updated comment to explain why Newlib headers should go first (amended edit) |
smlng
approved these changes
Feb 16, 2017
Member
|
lets wait for a final check by Murdock, afterwards ACK and GO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes to the include path handling when building with LLVM/Clang:
The first part makes native use the system default headers instead of trying to use GCC headers for the host system when GCC is installed alongside Clang.
The second part ensures that Newlib headers can override the GCC headers when building with Clang. In particular, Clang-3.9.1 seems to choke when building the unit tests for atomic when using the stdatomic.h from GCC-6.3.0. Newlib contains another version of stdatomic.h (which in turn seems to stem from FreeBSD) which works with both GCC and Clang, and even the old GCC-4.6 (msp430).