Skip to content

llvm: hide redefines of atomic sync operations#6598

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/llvm/hide_atomic_sync
Feb 14, 2017
Merged

llvm: hide redefines of atomic sync operations#6598
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/llvm/hide_atomic_sync

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Feb 14, 2017

fixes #6595

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system labels Feb 14, 2017
@smlng smlng self-assigned this Feb 14, 2017
@smlng smlng requested a review from jnohlgard February 14, 2017 09:55
@smlng smlng mentioned this pull request Feb 14, 2017
Closed
jnohlgard
jnohlgard approved these changes Feb 14, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I did not however get any errors like the ones in #6595 even without this patch. (Clang 3.9.1 on Linux)

@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 14, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 14, 2017

@gebart I use the default clang from macOS Sierra its internal version is LLVM 8.000 something.

When I try to compile I get the following error, same as in #6595

BOARD=native TOOLCHAIN=llvm make 
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Building application "hello-world" for "native" with MCU "native".

"/Library/Developer/CommandLineTools/usr/bin/make" -C /Developers/github/smlng/RIOT/boards/native
"/Library/Developer/CommandLineTools/usr/bin/make" -C /Developers/github/smlng/RIOT/boards/native/drivers
"/Library/Developer/CommandLineTools/usr/bin/make" -C Developers/github/smlng/RIOT/core
/Developers/github/smlng/RIOT/core/atomic_c11.c:354:6: error: definition of builtin function
      '__sync_synchronize'
void __sync_synchronize(void) {
     ^
1 error generated.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 14, 2017

With this PR it works ...

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Feb 14, 2017

I have the same error as @smlng, fixed by this PR. (clang 3.9.1, on Arch Linux)

@kaspar030 kaspar030 merged commit c63e33a into RIOT-OS:master Feb 14, 2017
@smlng smlng deleted the pr/llvm/hide_atomic_sync branch May 31, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees

@smlng smlng

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: Build with TOOLCHAIN=llvm fails on cortexm and native

3 participants

@smlng @kaspar030 @jnohlgard