Skip to content

periph/i2c: remodeling part 1: deprecate existing API#6575

Closed
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
haukepetersen:opt_periph_i2c_rename
Closed

periph/i2c: remodeling part 1: deprecate existing API#6575
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
haukepetersen:opt_periph_i2c_rename

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Feb 8, 2017 •
edited
Loading

supersedes #4926

For the remodeling of the I2C interface, I propose i different path than we took for the spi interface:

This PR is renaming the old I2C API to i2c_depr_:

git grep -l 'i2c_init_master' | xargs sed -i 's/i2c_init_master/i2c_depr_init_master/g'
git grep -l 'i2c_acquire' | xargs sed -i 's/i2c_acquire/i2c_depr_acquire/g'
git grep -l 'i2c_release' | xargs sed -i 's/i2c_release/i2c_depr_release/g'
git grep -l 'i2c_read_bytes' | xargs sed -i 's/i2c_read_bytes/i2c_depr_read_bytes/g'
git grep -l 'i2c_read_byte' | xargs sed -i 's/i2c_read_byte/i2c_depr_read_byte/g'
git grep -l 'i2c_read_regs' | xargs sed -i 's/i2c_read_regs/i2c_depr_read_regs/g'
git grep -l 'i2c_read_reg' | xargs sed -i 's/i2c_read_reg/i2c_depr_read_reg/g'
git grep -l 'i2c_write_bytes' | xargs sed -i 's/i2c_write_bytes/i2c_depr_write_bytes/g'
git grep -l 'i2c_write_byte' | xargs sed -i 's/i2c_write_byte/i2c_depr_write_byte/g'
git grep -l 'i2c_write_regs' | xargs sed -i 's/i2c_write_regs/i2c_depr_write_regs/g'
git grep -l 'i2c_write_reg' | xargs sed -i 's/i2c_write_reg/i2c_depr_write_reg/g'
git grep -l 'i2c_poweron' | xargs sed -i 's/i2c_poweron/i2c_depr_poweron/g'
git grep -l 'i2c_poweroff' | xargs sed -i 's/i2c_poweroff/i2c_depr_poweroff/g'

git grep -l 'periph/i2c_depr.h' | xargs sed -i 's/periph\/i2c.h/periph\/i2c_depr.h/g'

@haukepetersen haukepetersen added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Feb 8, 2017
@haukepetersen haukepetersen added this to the Release 2017.04 milestone Feb 8, 2017
This was referenced Feb 8, 2017
Closed
Closed
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Feb 8, 2017

The CI's says that u8g2 pkg needs to be adapted as well.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Feb 9, 2017

Oh man, always these packages... Will fix.

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 9, 2017
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Feb 9, 2017 •
edited
Loading

added patch for u8g2 package.

@dylad dylad mentioned this pull request Feb 10, 2017
Merged
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Feb 24, 2017

needs rebase

@smlng smlng mentioned this pull request Feb 28, 2017
Merged
@aabadie aabadie mentioned this pull request Mar 17, 2017
Merged
@kaspar030 kaspar030 modified the milestone: Release 2017.04 Apr 21, 2017
@aabadie aabadie modified the milestone: Release 2017.10 Jun 23, 2017
@PeterKietzmann PeterKietzmann mentioned this pull request Nov 27, 2017
Closed
@smlng smlng removed this from the Release 2018.01 milestone Jan 12, 2018
@smlng smlng added this to the Release 2018.04 milestone Jan 12, 2018
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Feb 26, 2018

closing this, as IMHO a feature branch approach is the way to go with the remodeling.

@gschorcht gschorcht mentioned this pull request Dec 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jnohlgard jnohlgard

@DipSwitch DipSwitch

@aabadie aabadie

@kaspar030 kaspar030

@PeterKietzmann PeterKietzmann

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

8 participants

@haukepetersen @aabadie @jnohlgard @DipSwitch @kaspar030 @PeterKietzmann @smlng @dylad