Skip to content

drivers/cc110x: add xtimer as module dependency#6454

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/drivers/cc110x_fix_deps
Jan 23, 2017
Merged

drivers/cc110x: add xtimer as module dependency#6454
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/drivers/cc110x_fix_deps

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 23, 2017

adds missing dependency, this popped up during test of #5469 and #6453 respectively when compiling the kw2xrf driver test for board msba2 with cc110x. The latter needs xtimer, linker error without this fix:

/RIOT/tests/driver_kw2xrf/bin/msba2/cc110x.a(cc110x-spi.o): In function `_xtimer_tsleep32':
/RIOT/sys/include/xtimer/implementation.h:147: undefined reference to `_xtimer_tsleep'
/RIOT/tests/driver_kw2xrf/bin/msba2/cc110x.a(cc110x.o): In function `_xtimer_tsleep32':
/RIOT/sys/include/xtimer/implementation.h:147: undefined reference to `_xtimer_tsleep'
/RIOT/sys/include/xtimer/implementation.h:147: undefined reference to `_xtimer_tsleep'
collect2: error: ld returned 1 exit status
make: *** [all] Error 1

@smlng smlng mentioned this pull request Jan 23, 2017
Merged
@smlng smlng added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers labels Jan 23, 2017
@smlng smlng added this to the Release 2017.01 milestone Jan 23, 2017
@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers and removed Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers labels Jan 23, 2017
PeterKietzmann
PeterKietzmann approved these changes Jan 23, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit 808f954 into RIOT-OS:master Jan 23, 2017
@smlng smlng deleted the pr/drivers/cc110x_fix_deps branch January 27, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees

@kaspar030 kaspar030

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlng @PeterKietzmann @kaspar030