cc110x: only handle NETOPT_PROTO if gnrc_netif module is present#6373
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Jan 18, 2017
Merged
Conversation
The cc110x_t::proto field is only present when the `gnrc_netif` module is present. Handling its corresponding `NETOPT_PROTO` value leads to a compile error when trying to compile without GNRC.
This was referenced Jan 15, 2017
PeterKietzmann
approved these changes
Jan 18, 2017
Member
PeterKietzmann
left a comment
There was a problem hiding this comment.
Makes sense. IMO we can merge but the driver needs rework anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc110x_t::proto field is only present when the
gnrc_netifmoduleis present. Handling its corresponding
NETOPT_PROTOvalue leads to acompile error when trying to compile without GNRC.