Skip to content

jenkins: add initial config#6258

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
cgundogan:pr/jenkins
Jan 12, 2017
Merged

jenkins: add initial config#6258
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
cgundogan:pr/jenkins

Conversation

@cgundogan
Copy link
Copy Markdown
Member

@cgundogan cgundogan commented Dec 21, 2016 •
edited by haukepetersen
Loading

Rationale: I am currently evaluating the performance of Jenkins and for this a Jenkinsfile is necessary.

Jenkins is able to detect PRs and branches when a Jenkinsfile is included in the root directory.
Such a Jenkinsfile orchestrates a build's operation (much like .travis.yml for Travis).
This PR is WIP and feedback is very welcome.

@cgundogan cgundogan added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Dec 21, 2016
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Dec 21, 2016

Ok, so whats the plan? We merge as soon as Jenkins builds properly?

@OlegHahm OlegHahm added Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework labels Dec 21, 2016
@smlng smlng mentioned this pull request Dec 22, 2016
Closed
@cgundogan cgundogan force-pushed the pr/jenkins branch 22 times, most recently from 5641edb to 27b7b84 Compare December 23, 2016 13:47
@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 11, 2017
@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 11, 2017
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 11, 2017

Shouldn't Jenkins wait for the "Ready for CI" label, too?

@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 11, 2017

The Jenkinsfile has no impact on Murdock, so I removed the Ready for CI build label to free up Murdock's Q for other important PRs

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 11, 2017

I see - but in principle Jenkins is able to react on Github labels?

@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 11, 2017

In theory yes, but I am currently failing to let Jenkins react correctly on label events. I will get this PR merged once it shows green and from there we can tackle further. Currently, every commit push would generate a build (as it used to be for travis way back in time). A simple semi-solution could be to look at the labels from within the Jenkinsfile (curl+GitHub API), but there is still the problem, that a null-commit would be necessary to trigger another build. But then again, are there many cases where the same commit must be build several times?

@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 11, 2017

that a null-commit would be necessary to trigger another build

and, ofcourse, it is also possible to trigger a build from the Jenkins GUI directly.

@smlng smlng mentioned this pull request Jan 12, 2017
Merged
@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 12, 2017

@RIOT-OS/maintainers from my point of view this PR is ready to merge, so that we can observe how Jenkins performs on production. However, I am not able to merge my own PR, is anyone willing to hit the button? @kaspar030 (: ?

kaspar030
kaspar030 approved these changes Jan 12, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! ;) ACK!

@smlng
Copy link
Copy Markdown
Member

smlng commented Jan 12, 2017 •
edited by cgundogan
Loading

btw. all RIOT-OS maintainers are allow to login into Jenkins with their github credentials. They can trigger or cancel builds of PRs.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 12, 2017

Seems like the script for the nightly builds isn't as it supposed to be (stderr: fatal: Couldn't find remote ref refs/pull/${GITHUB_PR_NUMBER}/merge. Doesn't make much sense if it is supposed to build master ;-))

@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 12, 2017

the nightly config. was just an experiment some weeks ago. @smlng do you want to save the config. before I remove the job?

@smlng
Copy link
Copy Markdown
Member

smlng commented Jan 12, 2017

ah simply delete it, I'll recreate it later ...

@smlng
Copy link
Copy Markdown
Member

smlng commented Jan 12, 2017

btw. rebased my PRs #6333 and #6326 onto new master both are building in jenkins now! the latter with OS X enabled

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 12, 2017

How do I add mine? I have a native PR in the pipeline (#6337) which I would very much like to test :-)

@cgundogan
Copy link
Copy Markdown
Member Author

cgundogan commented Jan 12, 2017

simply rebasing to current master should suffice (:

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 12, 2017

Meh 😥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@miri64 miri64

@kaspar030 kaspar030

@smlng smlng

Labels

Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cgundogan @kaspar030 @OlegHahm @smlng @miri64