Skip to content

saml21: add I2C support#5992

Closed
dylad wants to merge 1 commit intoRIOT-OS:masterfrom
dylad:saml21_i2c
Closed

saml21: add I2C support#5992
dylad wants to merge 1 commit intoRIOT-OS:masterfrom
dylad:saml21_i2c

Conversation

@dylad
Copy link
Copy Markdown
Member

@dylad dylad commented Oct 25, 2016

Add I2C support to SAML21 & SAML21-Xplained board
Most of the change are located in the i2c init function, saml21 and samd21 don't have the same clock management.
I added specific init function for saml21 under the sam21_common directory. Maybe it was not the best way to do it. Any thoughts ?

Signed-off-by: dlad <dylan.laduranty@mesotic.com>
@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers labels Oct 26, 2016
@kaspar030
Copy link
Copy Markdown
Contributor

I don't have the board anymore... @haukepetersen ?

@haukepetersen
Copy link
Copy Markdown
Contributor

sorry for the delay. Looks to me, like #6205 is the more generic approach and as it's build upon this work, does anyone opposed to going with #6205? @dylad: would that be ok for you?

@dylad
Copy link
Copy Markdown
Member Author

dylad commented Dec 15, 2016

Hi @haukepetersen,
I'm not oppose to anything as long as RIOT supports I2C on saml21 board.
and also I would gladly help to improve saml21 support on RIOT.
Should I close this PR ?

@haukepetersen
Copy link
Copy Markdown
Contributor

perfect: I just opened #6223 to improve the sam0 structure and clarity a bit -> would you maybe mind to have a look at those changes?!

@haukepetersen
Copy link
Copy Markdown
Contributor

closed in favor of #6205 (and #6223)

@dylad dylad deleted the saml21_i2c branch May 7, 2017 09:06
@dylad dylad restored the saml21_i2c branch May 7, 2017 19:30
@dylad dylad deleted the saml21_i2c branch August 30, 2017 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants