dist/tools/cc2538-bsl: fixing pep8 and python 2 & 3 compatibility in cc2538 bsl script#5909
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Oct 19, 2016
Merged
Conversation
Member
|
My two cents: I share @cgundogan's concerns about upstream compatibility #5784 (comment) |
kYc0o
approved these changes
Oct 5, 2016
Contributor
kYc0o
left a comment
There was a problem hiding this comment.
Confirm it works on OS X either with python and python3. ACK
Contributor
|
Waiting for upstream repo change (if accepted) to merge this one. |
d6ba4ef to
7ad2bfd
Compare
7ad2bfd to
4e88205
Compare
Contributor
|
Upstream merging is taking a bit... We can merge it for the release anyways? |
Member
|
Was #5909 (comment) addressed? |
Contributor
Author
|
@miri64, yes but the upstream PR takes some time to be merged. |
Contributor
Author
|
Ok, so GO ! |
Member
|
(though only to undo my implicit NACK, I did not look too deep into this PR, nor tested it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a try to make cc2538 python 2 & 3 compliant and also pep 8 compliant (my python IDE was full of red dots...).