@OlegHahm I remember you were against this as you regularly compile with -O0 to debug?

Launching murdock to see if this would expose trouble...

We may need to take care of #if ENABLE_DEBUG.

We may need to take care of #if ENABLE_DEBUG.

Would that evaluate to true with ENABLE_DEBUG==0?

For example, gnrc_ipv6.c declares temporary buffer to format IP address:

#if ENABLE_DEBUG
static char addr_str[IPV6_ADDR_MAX_STR_LEN];
#endif

                DEBUG("ipv6: set packet source to %s\n",
                      ipv6_addr_to_str(addr_str, src, sizeof(addr_str)));

So we have to change it to:

#if ENABLE_DEBUG
static char addr_str[IPV6_ADDR_MAX_STR_LEN];
#else
static char addr_str[1];
#endif

or enable zero size arrays and change it to:

#if ENABLE_DEBUG
static char addr_str[IPV6_ADDR_MAX_STR_LEN];
#else
static char addr_str[0];
#endif

or change it to allocate the buffer on the stack.

@OlegHahm I remember you were against this as you regularly compile with -O0 to debug?

Oops, should have read this before. Well, yes, I guess everybody who's debugging is using -O0 quite often.

How about this?

#ifdef ELIMINATE_DEBUG_COMPLETELY
#define DEBUG(...)
#else
#define DEBUG(...) if (ENABLE_DEBUG) DEBUG_PRINT(__VA_ARGS__)
#endif

[edit] Clang and GCC seems to eliminate if (0) { ... } at -O0 optimization level [/edit]

@kaspar030 can you retake this? Since WIP label is set I think it's better to put it in the next release.

• squashed

Sorry, I thought all #if ENABLEDEBUG should be replaced by if (ENABLE_DEBUG) like done here:

Actally, yes. But I propose going in steps. This PR makes all DEBUG() compile, and fixes all #if ENABLE_DEBUG where it caused errors. The others, we can do over time.

@cladmi are we good here, or do you have any doubts/comments? Otherwise, we should merge this.

Well then, ACK & GO!