Skip to content

core: atomic: add atomic_and() and atomic_or()#4888

Closed
kaspar030 wants to merge 1 commit intoRIOT-OS:masterfrom
kaspar030:add_atomic_and_or
Closed

core: atomic: add atomic_and() and atomic_or()#4888
kaspar030 wants to merge 1 commit intoRIOT-OS:masterfrom
kaspar030:add_atomic_and_or

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

No description provided.

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! labels Feb 24, 2016
@kaspar030 kaspar030 assigned Kijewski and jnohlgard and unassigned Kijewski Feb 24, 2016
@kaspar030
Copy link
Copy Markdown
Contributor Author

@gebart, didn't you initially add the atomic functions?

I used atomic_and() and atomic_or() in an early version of thread flags. No I don't need them anymore, but I had the commit lying around...

@jnohlgard
Copy link
Copy Markdown
Member

yep, I did. The atomic implementations are ready for an overhaul though, based on the discussions about volatile in #4700 and maybe using the compiler builtins as far as possible

@miri64 miri64 modified the milestone: Release 2016.07 Mar 29, 2016
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jul 25, 2016

Feature freeze -> postponed.

@kYc0o kYc0o modified the milestones: Release 2016.10, Release 2016.07 Jul 25, 2016
@jnohlgard
Copy link
Copy Markdown
Member

Closing in favour of #5688 which gets rid of our atomic.h header and supports all compiler builtins and C11 atomics in GCC+Clang.

@jnohlgard jnohlgard closed this Jul 30, 2016
@kaspar030 kaspar030 deleted the add_atomic_and_or branch August 8, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants