Added cc2538-bsl as a submodule + update#4237
Closed
JelmerT wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
Added cc2538-bsl as a submodule + update#4237JelmerT wants to merge 3 commits intoRIOT-OS:masterfrom
JelmerT wants to merge 3 commits intoRIOT-OS:masterfrom
Conversation
Member
|
@JelmerT, thanks for this proposal. Actually, we decided some time ago not include submodules in RIOT, because they are not so easy to use and may cause several problems, Instead we decided to include external tools as so called "packages". See the documentation in the wiki. Do you think this could be feasible for the bootloader tool as well? |
Contributor
Author
|
I'll have to look into this. A package seems overkill for a 1 file uploader script. I'll close this for now and reopen once I have time to write the extra makefiles. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the cc2538-bsl script as a submodule. It follows my repo at https://github.com/JelmerT/cc2538-bsl .
Including the script as a submodule makes it easier to keep the script up to date, and for user to pull in possible bug fixes more easily.
We just added a lot new features to the script and bumped the version to
2.0. One of the main improvements is support for the CC13xx and CC26xx chips.The submodule will be automatically checked out by git when a user clones a new version of the RIOT repo. For existing clones you might need to use
git submodule update --initI will keep this submodule here up to date on major version changes of the script.
I also updated the RE-MOTE makefile to not force the upload speed when using the script. @alignan can confirm if this doesn't break anything.