Skip to content

cpu/cortex-m: add all-debug target#4188

Closed
DipSwitch wants to merge 1 commit intoRIOT-OS:masterfrom
DipSwitch:makefile_all_debug_cortexm
Closed

cpu/cortex-m: add all-debug target#4188
DipSwitch wants to merge 1 commit intoRIOT-OS:masterfrom
DipSwitch:makefile_all_debug_cortexm

Conversation

@DipSwitch
Copy link
Copy Markdown
Member

@DipSwitch DipSwitch commented Oct 29, 2015

Request to include the Makefile target all-debug for the cortex-m serie CPU's.

@LudwigKnuepfer LudwigKnuepfer added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Oct 29, 2015
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Oct 30, 2015

@LudwigKnuepfer no job for you? I'd like to assign you ;-) !

@LudwigKnuepfer LudwigKnuepfer added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 30, 2015
@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Oct 30, 2015

I don't quite understand - I thought debugging symbols are always included in the hexfile elf file without the need for -g ..?

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Oct 31, 2015

I also thought so.

@LudwigKnuepfer LudwigKnuepfer self-assigned this Oct 31, 2015
@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Nov 3, 2015

Oops, this is true. But I would like to see the -Os disabled. :)

@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Nov 3, 2015

And it would be nice to have the target itself existing aswell.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Nov 3, 2015

@DipSwitch CFLAGS_OPT=-O0 make all?

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Nov 4, 2015

And it would be nice to have the target itself existing aswell.

For consistency with native, this might make sense.

@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Dec 1, 2015

This way you don't have to change the default build target in your IDE if you switch between native and a board =)

LudwigKnuepfer
LudwigKnuepfer reviewed Dec 2, 2015
View reviewed changes
cpu/cortexm_common/Makefile.include Outdated
Copy link
Copy Markdown
Member

@LudwigKnuepfer LudwigKnuepfer Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, will you remove this superfluous line? Then we can merge.

Copy link
Copy Markdown
Member

@LudwigKnuepfer LudwigKnuepfer Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought: it probably makes more sense to move the all-debug dependency declaration to some global location and purge it here and from the respective location in native.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Dec 2, 2015

@DipSwitch CFLAGS_OPT=-O0 make all?

Again, why not override on command line edit or IDE's environment settings?
CFLAGS_OPT=-O0 -g make all should be honoured by all targets and do exactly what you want. Is there an advantage having it as a specific make target?

@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Dec 2, 2015 via email

@DipSwitch DipSwitch force-pushed the makefile_all_debug_cortexm branch from ede831a to 51f2507 Compare December 3, 2015 08:43
@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Dec 3, 2015

Removed line, but maybe it's better to move it to a general location so also the MSP430 can provide from this.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 4, 2015

Removed line, but maybe it's better to move it to a general location so also the MSP430 can provide from this.

I agree (and said so ;))

@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Dec 4, 2015 via email

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 4, 2015

How about Makefile.include?

@DipSwitch DipSwitch mentioned this pull request Dec 5, 2015
Closed
@DipSwitch
Copy link
Copy Markdown
Member Author

DipSwitch commented Dec 5, 2015

Followup PR made.

@DipSwitch DipSwitch closed this Dec 5, 2015
@DipSwitch DipSwitch deleted the makefile_all_debug_cortexm branch December 16, 2015 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DipSwitch @PeterKietzmann @LudwigKnuepfer @OlegHahm @kaspar030