LIS3MDL driver implementation for LimiFrog V1#3495
LIS3MDL driver implementation for LimiFrog V1#3495haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
@PeterKietzmann Here's the initial create for the LIS3MDL driver. It should be testable, when the port is done, I hope I didn't forgot anything :-). |
tests/driver_lis3mdl/main.c
Outdated
There was a problem hiding this comment.
Please check the https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions - you could also check what astyle does for you.
This particular case:
if (...)
{should become
if (...) {There was a problem hiding this comment.
@LudwigOrtmann Okey, Thanks for the link.
|
@ReneHerthel thx! Running astyle is a good idea (maybe before each PR you open). The bluefrog port-PR should be available in some days. |
drivers/lis3mdl/lis3mdl.c
Outdated
There was a problem hiding this comment.
Can you briefly explain what this does?
There was a problem hiding this comment.
@PeterKietzmann It blocks the update process for magnetic data, until MSb and LSb was read.
There was a problem hiding this comment.
And you are disabling that functionality with this command, right? Why?
There was a problem hiding this comment.
@PeterKietzmann Yes, I thought it's better to block the data update process within the registers until the entire data has been read.
There was a problem hiding this comment.
Ok I understand that point. Maybe one should spend some more thoughts if this is wanted. The questions should be: 1. when are the values updated if this functionality is disabled and 2. what if the data is not being read for a while? The measured values may be outdated at that time.
There was a problem hiding this comment.
@PeterKietzmann Hmm, okey. Yes two good Points, maybe I should remove this for the Moment, and later, when we can test the device, we can look, if this is a good idea or not.
There was a problem hiding this comment.
Do whatever you think is best :-) and we'll prove it then.
|
@ReneHerthel the PR looks really good. Nice! |
|
I think this PR contains an error: http://www.limifrog.io/2015/07/la-bluefrog-changes-name/ ;-) |
|
But AFAIK the limifrog has a slightly different hardware. That's why we stayed with "bluefrog". I will ask Xavier |
|
Ah, okay, I thought it was a name-only change. |
|
The basic support for the LimiFrog board has been merged with #3509. Next, we need to test this driver with the on-board sensor. |
|
Rebase. |
|
@PeterKietzmann The basic functionality should work now! AND there is some code missing in the /cpu/stm32l1/periph/i2c.c, just to remind. |
|
Jippie! Hope we can make some progress next week. Regarding the i2c driver for stm32l1 CPUs: @ReneHerthel, @katezilla, @haukepetersen, @thomaseichinger anyone willing to extend/renew this peripheral driver? Any capacities? |
|
(PS: We need to use |
|
@PeterKietzmann I use I2C_1 for this. |
|
@PeterKietzmann Would you like to test my latest work? |
There was a problem hiding this comment.
any reason to enable the temp sensor while not using it?
There was a problem hiding this comment.
ups, never mind. Overlooked the reading of temp values at the bottom of the main...
|
Realistic to have this ready until next Wednesday? |
drivers/include/lis3mdl.h
Outdated
| */ | ||
| typedef struct { | ||
| i2c_t i2c; /** I2C device */ | ||
| uint8_t addr; /** Magnometer I2C address */ |
There was a problem hiding this comment.
can you fix the indent here
|
tested it, magnometer works, if close to laptop or phone it shows higher values. |
d184198 to
d72c2be
Compare
|
@katezilla I addressed your comments. |
|
Added CI build label to compile-check that PR |
|
Please rebase this PR and replace all uses of vtimer with xtimer |
af1bf3e to
d905e5a
Compare
|
Changed from xtimer to vtimer and rebase + squash |
671b789 to
44ee645
Compare
|
ACK and go |
LIS3MDL driver implementation for LimiFrog V1
Original Issue: board: RIOT port for LimiFrof V1 #3020