ng_pktbuf: simplify API by extension#3458
Conversation
sys/include/net/ng_pktbuf.h
Outdated
There was a problem hiding this comment.
I would vote for also simplifying this and copy data in any case, so we drop the checks if data is already in the buf...
|
+1 for the changes! |
|
Addressed @haukepetersen's comments |
b9b6a67 to
50a7f9b
Compare
|
Replaced |
069837b to
bace359
Compare
|
Squashed. |
|
Do we need to merge this before #3496 or can we just close it? |
|
Anyway, I assume that @haukepetersen's "+1" was an ACK :-) ? |
|
@PeterKietzmann we need #3496 to have working code. But when we merge #3496 this will be marked as merged, too. I'd prefer that over just closing it, because it would show a more precise history of what happened here than when we close it. |
|
So my verdict is: leave this open, but merge #3496 ;-) |
|
Fine. Honestly I just wanted to activate communication in the hope of a soonish merge |
This simplifies the `ng_pktbuf` API by adding a new function `ng_pktbuf_mark()` which takes over some functionality of `ng_pktbuf_add()`. `size == 0` for `ng_pktbuf_add()` is now illegal.
bace359 to
41b0a26
Compare
This simplifies the
ng_pktbufAPI by adding a new functionng_pktbuf_mark()which takes over some functionality ofng_pktbuf_add().size == 0forng_pktbuf_add()is now illegal.TODO: Change implementation(s) and usage of these functions.