sys/psa_crypto: unify buffer size size handling for ed25519 backends#21821
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Nov 3, 2025
Merged
sys/psa_crypto: unify buffer size size handling for ed25519 backends#21821mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
crasbe
reviewed
Oct 27, 2025
Contributor
crasbe
left a comment
There was a problem hiding this comment.
The static test has some complaints about long lines and ifs without brackets.
benpicco
approved these changes
Oct 31, 2025
8579989 to
36e09cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Ed25519 has fixed sizes for private keys, public keys, and signatures. Those can be checked on the algorithm dispatch layer once instead of duplicating code in the backends.
Additionally, we now consistently zero out key-material buffers on the stack in both the hardware and software backend.
Testing procedure
make -C tests/sys/psa_crypto_eddsa all flash teststill succeeds forBOARD=native(automatically usingc25519as software backend) and forBOARD=nrf52840dk(automatically usingdriver_cryptocell_310as HW backend).