Skip to content

nativenet: adapt for netdev event handler#2164

Closed
miri64 wants to merge 10 commits intoRIOT-OS:masterfrom
miri64:nativenet/fix/netapi-event-handler
Closed

nativenet: adapt for netdev event handler#2164
miri64 wants to merge 10 commits intoRIOT-OS:masterfrom
miri64:nativenet/fix/netapi-event-handler

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Dec 8, 2014

nativenet specific follow-up on #2163 and fix so #1968 can work properly (addresses #1968 (comment))

Based on #2163

@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Platform: native Platform: This PR/issue effects the native platform Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: network Area: Networking labels Dec 8, 2014
@miri64 miri64 added this to the Release 2014.12 milestone Dec 8, 2014
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 8, 2014

(Tested with tests/nativenet_netdev in rebased version of #1969)
Tested with tests/netdev

@miri64 miri64 force-pushed the nativenet/fix/netapi-event-handler branch from 1e628a4 to 5637e69 Compare December 8, 2014 17:20
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 8, 2014
@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 9, 2014
LudwigKnuepfer
LudwigKnuepfer reviewed Dec 15, 2014
View reviewed changes
cpu/native/net/interface.c Outdated
Copy link
Copy Markdown
Member

@LudwigKnuepfer LudwigKnuepfer Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can reduce the indentation a bit...

@miri64 miri64 force-pushed the nativenet/fix/netapi-event-handler branch from 5637e69 to a367d45 Compare December 16, 2014 15:25
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 16, 2014

Rebased to #2163, adapted for changes there and addressed comments

@OlegHahm OlegHahm modified the milestones: Release 2014.12, Release NEXT MAJOR Dec 18, 2014
fnack
fnack reviewed Jan 3, 2015
View reviewed changes
cpu/native/net/interface.c Outdated
Copy link
Copy Markdown
Member

@fnack fnack Jan 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 5, 2015

Addressed comment

@fnack fnack mentioned this pull request Jan 6, 2015
Closed
@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Network Stack Task Force Feb 6, 2015
@OlegHahm OlegHahm added NSTF and removed NSTF labels Feb 6, 2015
@miri64 miri64 modified the milestone: Network Stack Task Force Feb 8, 2015
@miri64 miri64 added the State: archived State: The PR has been archived for possible future re-adaptation label Feb 8, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 8, 2015

Abandoned, but memo'd for @LudwigOrtmann's port according to #2278

@miri64 miri64 closed this Feb 8, 2015
@miri64 miri64 deleted the nativenet/fix/netapi-event-handler branch February 8, 2015 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels

Area: network Area: Networking CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: native Platform: This PR/issue effects the native platform Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: archived State: The PR has been archived for possible future re-adaptation State: waiting for other PR State: The PR requires another PR to be merged first

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @fnack @LudwigKnuepfer @OlegHahm