boards/lora-e5-dev: set OpenOCD _TARGETNAME variable to fix flashing#21615
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Jul 22, 2025
Merged
boards/lora-e5-dev: set OpenOCD _TARGETNAME variable to fix flashing#21615crasbe merged 1 commit intoRIOT-OS:masterfrom
crasbe merged 1 commit intoRIOT-OS:masterfrom
Conversation
crasbe
reviewed
Jul 18, 2025
Contributor
|
Please also adapt the title of the PR and the commit message to our commit convention, which you can find here: https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions A suitable title (for the current state) would be e.g. |
Contributor
|
You re-requested a review, but you didn't push any changes yet? |
Contributor
Author
Sorry I forgot, it would be ok now |
crasbe
approved these changes
Jul 22, 2025
Contributor
crasbe
left a comment
There was a problem hiding this comment.
Looks good, please squash your commits into one :)
553fdbe to
d666ed8
Compare
Contributor
Author
done ;) |
Contributor
|
Thank you for fixing this and congratulations for your first merged PR 🥳 |
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch fixes an issue in the OpenOCD STM32WLX target config (
target/stm32wlx.cfg) where the_TARGETNAMEvariable is not defined after creating the CPU target.Board configs relying on
_TARGETNAMEfail withcan't read "_TARGETNAME": no such variableduring flashing or debugging.Per the OpenOCD Config File Guidelines,
_TARGETNAMEshould be set in the target config, but it was removed in a previous commit (diff).This patch sets
_TARGETNAMEexplicitly in theopenocd.cfgforlora-e5-devto point to the main CPU target ($_CHIPNAME.cpu0), restoring expected behavior.Testing procedure
With this fix, flashing the
examples/basic/hello-worldexample now works correctly.Issues/PRs references
#21614