buildsystem: Fix Supported Board List in info-build#21361
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Apr 4, 2025
Merged
buildsystem: Fix Supported Board List in info-build#21361mguetschow merged 1 commit intoRIOT-OS:masterfrom
info-build#21361mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
mguetschow
reviewed
Apr 4, 2025
Contributor
mguetschow
left a comment
There was a problem hiding this comment.
Great, thanks for looking into this! 🤗
fd5a853 to
7169214
Compare
Contributor
Author
You're welcome. I learned a lot about Make again and it's nice when there's a simple fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
@mguetschow documented in #21019 that the
info-buildtarget does not show the all the boards that are actually supported, depending on the board that is set on the command line.The reason for this is that the Make system creates a lot of environment variables and hands them down to the next instance. In this case, the
FEATURES_REQUIREDvariable was set and had some requirements that not all of the supported boards could fulfill, therefore they were (errorneously) sorted out.Therefore this PR starts the submake in a clean environment, so that Make is not influenced by what's set by the parent.
Testing procedure
With
master:With this PR:
Issues/PRs references
Fixes #21019.