bluetil: Ensure advertisement length does not exceed pkt len#20881
bluetil: Ensure advertisement length does not exceed pkt len#20881benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
lgtm. The CI has nitpicks, though. |
|
Maybe @BOZHENG001 wants to have a look. |
|
The code meets its purpose. I never tried, but it seems some errors may occur if the advertisement length exceeds the packet length? In the BLE standard, I do not see such a limit for the advertisement packet length? |
|
I am unsure what action your comment demands? |
|
Sorry for the confusion. Just wanted to know if our change meets the BLE standard or not. If yes, of course I will have no objection. |
|
Okay, took for ever but I found it, page 1432 in the current bluetooth spec. I think my fix is within the spec. |
|
Cool cool, thanks for the explanation. As long as it meets the standard, we are still BLE. |
miri64
left a comment
There was a problem hiding this comment.
I interpret @BOZHENG001's last comment as ACK. :-)
Contribution description
Hey 🦪
this fixes an erroneous advertisement parsing, in which the length of the adv. was inherently trusted.
Testing procedure
Good review should be sufficient.