tests/periph/selftest_shield: timer allocation conflict#20096
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Nov 21, 2023
Merged
tests/periph/selftest_shield: timer allocation conflict#20096maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
reviewed
Nov 20, 2023
- Detect when the same timer is used by `ztimer` (pulled in as dependency for a peripheral driver, e.g. `periph_adc` on STM32F3) and the test application - Try to provide a better default (e.g. `TIMER_DEV(1)` when `ztimer_periph_timer` is in use, `TIMER_DEV(0)` otherwise)
3197578 to
57488a5
Compare
benpicco
approved these changes
Nov 20, 2023
Member
Author
|
Thx :-) |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
ztimer(pulled in as dependency for a peripheral driver, e.g.periph_adcon STM32F3) and the test applicationTIMER_DEV(1)whenztimer_periph_timeris in use,TIMER_DEV(0)otherwise)Testing procedure
nucleo-f303reinmaster: A hard fault is triggered duringadc_init()due to a conflict in the use of the sameperiph_timerperipheral by the app and ztimertimer_init()failing (because the board only has a single timer peripheral exposed)Issues/PRs references
None