sys/shell/gnrc_netif: don't always build lora options with ifconfig#19490
Merged
bors[bot] merged 4 commits intoRIOT-OS:masterfrom May 9, 2023
Merged
sys/shell/gnrc_netif: don't always build lora options with ifconfig#19490bors[bot] merged 4 commits intoRIOT-OS:masterfrom
bors[bot] merged 4 commits intoRIOT-OS:masterfrom
Conversation
0136134 to
c5bba9f
Compare
1b15dbb to
eaf6a25
Compare
Just build them if the shell_cmd_gnrc_netif_lora module is pulled in
eaf6a25 to
ba92b3f
Compare
Contributor
Author
|
@jia200x can you have a look at this one ? |
jia200x
approved these changes
May 9, 2023
Member
jia200x
left a comment
There was a problem hiding this comment.
ACK. Tested on b-l072z-lrwan1. I could select shell_cmd_gnrc_netif without selecting LoRa specific commands.
Contributor
Author
|
bors merge |
1 similar comment
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a follow-up of #19466 and should address #19466 (comment)
Testing procedure
Untested yet.
The testing procedure in #19466 should be the same.
Issues/PRs references
#19466