Skip to content

libschc: initial import as package#18515

Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
miri64:pkg/feat/libschc
Mar 2, 2023
Merged

libschc: initial import as package#18515
bors[bot] merged 2 commits intoRIOT-OS:masterfrom
miri64:pkg/feat/libschc

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 25, 2022 •
edited
Loading

Contribution description

This is part 1 of my takeover of #15040. The PR only contains the import of the pkg, not the GNRC module, which will be provided in part 2 as a separate PR.

I mostly updated to both the current version of libSCHC and RIOT, added tests, and adapted the overall style to be more RIOT-like and following our coding conventions.

Testing already revealed some usage problems (or maybe even bugs) with libSCHC. I will have a call with @bartmoons next week to discuss these.

TODOs
  • Adapt pre-configured rule in pkg/libschc/include/rules set more for general RIOT+LoRaWAN use cases
  • Increase test coverage of tests
  • Clean-up rule set for test application

Testing procedure

Run the provided tests with

make -C tests/pkg_libschc/ flash test

on a platform of your choice.

Issues/PRs references

Partial alternative to #15040

@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Aug 25, 2022
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Aug 25, 2022
@miri64 miri64 mentioned this pull request Aug 25, 2022
Closed
@miri64 miri64 force-pushed the pkg/feat/libschc branch 3 times, most recently from a6972ef to 0f80bc5 Compare August 26, 2022 08:57
@github-actions github-actions bot added Area: doc Area: Documentation Area: CI Area: Continuous Integration of RIOT components labels Aug 26, 2022
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 26, 2022
@miri64 miri64 force-pushed the pkg/feat/libschc branch 3 times, most recently from 1dd4af8 to a12018f Compare August 26, 2022 09:24
@miri64 miri64 added the CI: run tests If set, CI server will run tests on hardware for the labeled PR label Aug 26, 2022
@miri64 miri64 force-pushed the pkg/feat/libschc branch 2 times, most recently from 0f439c4 to b643136 Compare August 26, 2022 09:44
@github-actions github-actions bot added the Area: build system Area: Build system label Aug 26, 2022
@miri64 miri64 force-pushed the pkg/feat/libschc branch 2 times, most recently from 12604d1 to a75398d Compare August 26, 2022 09:56
@miri64 miri64 added CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 26, 2022
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 26, 2022
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 28, 2022
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 29, 2022
@miri64 miri64 removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Oct 17, 2022
@miri64 miri64 force-pushed the pkg/feat/libschc branch 5 times, most recently from 264fc92 to 5ebc12b Compare October 28, 2022 11:39
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 28, 2022
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 1, 2022
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 15, 2023

Rebased to current master and adopted for current libSCHC master (which saw some fixes in the wake of adopting pylibschc

@miri64 miri64 marked this pull request as ready for review February 15, 2023 12:29
@miri64 @bartmoons
libschc: initial import
566066a 
Co-Authored-By: boortmans <bart.moons@gmail.com>
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 22, 2023

This PR is ready for review in my opinion and required for me to seriously proceed on #18700.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 22, 2023

The libSCHC version may need some more bumps, but I would rather prefer to do that in master, than keeping track of a moving target here.

jia200x
jia200x approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
I tested this branch through #18700 and everything works as expected. Since this is still a (kind of) experimental feature, I think we should get it ASAP and continue improving from there.

Nice work btw!

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

Squashed and removed the temporary commit that restricted Murdock to the test.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

bors try

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

bors cancel
bors merge

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

bors t-

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

bors try-

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 2, 2023

Or for globs sake, bors try- already!

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Mar 2, 2023

Build failed (retrying...):

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Mar 2, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jia200x jia200x jia200x approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2023.04

Development

Successfully merging this pull request may close these issues.

6 participants

@miri64 @MrKevinWeiss @riot-ci @jia200x @kaspar030 @leandrolanzieri