drivers/mrf24j40: move CFLAG to Makefile.include#17792
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Mar 11, 2022
Merged
drivers/mrf24j40: move CFLAG to Makefile.include#17792bergzand merged 1 commit intoRIOT-OS:masterfrom
bergzand merged 1 commit intoRIOT-OS:masterfrom
Conversation
bergzand
approved these changes
Mar 11, 2022
Member
bergzand
left a comment
There was a problem hiding this comment.
Untested ack, don't have the radio with PA to test this
Contributor
Author
|
All green! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
CFLAGS should be added in
Makefile.includes. For mrf24j40 it was being done inMakefile.dep, so this corrects it.Testing procedure
mrf24j40mabut other variantIssues/PRs references
Split from #17789