Skip to content

drivers/*/Kconfig: Cleanup of simple drivers#17669

Merged
leandrolanzieri merged 83 commits intoRIOT-OS:masterfrom
MrKevinWeiss:pr/kconfig/netdrivers
Mar 9, 2022
Merged

drivers/*/Kconfig: Cleanup of simple drivers#17669
leandrolanzieri merged 83 commits intoRIOT-OS:masterfrom
MrKevinWeiss:pr/kconfig/netdrivers

Conversation

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss commented Feb 17, 2022

Contribution description

This will be a sweep of all the non-controversial kconfig changes in drivers now that we have some better ideas of modelling.

Testing procedure

Murdock green

Issues/PRs references

@MrKevinWeiss MrKevinWeiss added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Feb 17, 2022
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Feb 17, 2022
leandrolanzieri
leandrolanzieri reviewed Feb 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. Please also check some missing newlines

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Feb 22, 2022
@github-actions github-actions bot added the Area: LoRa Area: LoRa radio support label Feb 24, 2022
@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Feb 24, 2022
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components and removed Area: CI Area: Continuous Integration of RIOT components labels Feb 28, 2022
@MrKevinWeiss MrKevinWeiss force-pushed the pr/kconfig/netdrivers branch from b16ae34 to a8fe3da Compare March 2, 2022 13:07
@MrKevinWeiss
Copy link
Copy Markdown
Contributor Author

MrKevinWeiss commented Mar 2, 2022

83 commits... who wants to review? 👿

leandrolanzieri
leandrolanzieri reviewed Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very much needed cleanup! Here are some comments

@MrKevinWeiss
Copy link
Copy Markdown
Contributor Author

MrKevinWeiss commented Mar 4, 2022

OK, I think I have addressed the comments with the fixup, thanks for the review

@MrKevinWeiss MrKevinWeiss force-pushed the pr/kconfig/netdrivers branch from a0fe962 to ed02662 Compare March 4, 2022 13:17
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2022
@MrKevinWeiss
Copy link
Copy Markdown
Contributor Author

MrKevinWeiss commented Mar 9, 2022

Anything blocking this? I hope not to get caught in rebase hell.

@leandrolanzieri leandrolanzieri added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Mar 9, 2022
leandrolanzieri
leandrolanzieri approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! ACK

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Mar 9, 2022
@leandrolanzieri leandrolanzieri merged commit 34dc248 into RIOT-OS:master Mar 9, 2022
@MrKevinWeiss MrKevinWeiss deleted the pr/kconfig/netdrivers branch March 9, 2022 08:31
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
@aabadie aabadie mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.04

Development

Successfully merging this pull request may close these issues.

5 participants

@MrKevinWeiss @leandrolanzieri @benpicco @OlegHahm @fjmolinas