Skip to content

sys/ztimer64: PRIu64 requires stdio before inttypes#17589

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
kfessel:p-fix-ztimer64-print
Jan 30, 2022
Merged

sys/ztimer64: PRIu64 requires stdio before inttypes#17589
benpicco merged 1 commit intoRIOT-OS:masterfrom
kfessel:p-fix-ztimer64-print

Conversation

@kfessel
Copy link
Copy Markdown
Contributor

@kfessel kfessel commented Jan 28, 2022

Contribution description

adds stdio.h include in front of inttypes.h fixes:

ztimer64.c:298:26: error: expected ')' before 'PRIu64'
  298 |         printf("0x%08x:%" PRIu64 "\n", (unsigned)entry, entry->target);

Testing procedure

examples/hello-world$ USEMODULE=ztimer64_msec BOARD=nucleo-f767zi make clean all

with master:

ztimer64.c:298:26: error: expected ')' before 'PRIu64'
  298 |         printf("0x%08x:%" PRIu64 "\n", (unsigned)entry, entry->target);

with PR:
SUCCESS

Issues/PRs references

https://github.com/mirror/newlib-cygwin/blob/d079ab4d37ca37cef04e43aa333ab2b53c81699d/newlib/libc/include/inttypes.h#L216

@github-actions github-actions bot added the Area: sys Area: System label Jan 28, 2022
@kfessel kfessel added Area: timers Area: timer subsystems Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 28, 2022
@kfessel kfessel requested a review from kaspar030 January 28, 2022 16:57
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jan 28, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 28, 2022
@benpicco benpicco merged commit d0d4497 into RIOT-OS:master Jan 30, 2022
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.04

Development

Successfully merging this pull request may close these issues.

3 participants

@kfessel @benpicco @OlegHahm