.murdock: Kconfig test apps for all boards#17402
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Dec 15, 2021
Merged
Conversation
kaspar030
reviewed
Dec 15, 2021
.murdock
Outdated
|
|
||
| if [ ${should_check_kconfig_hash} != 0 ]; then | ||
| if [ ${kconfig_test_hash} != ${test_hash} ]; then | ||
| tput setaf 1 |
Contributor
Author
There was a problem hiding this comment.
Ahh this is just temporary, when I run in my console it shows this warning in red, easier to scan while things are going. Please ignore.
Contributor
|
LGTM. |
47a321a to
6e99c75
Compare
Contributor
Author
|
These tests seem to be working. I think there are still some low hanging fruit boards but maybe we should get this in first and remove them later. May I squash and clean? |
Contributor
|
Yes, please squash! |
Introduce the TEST_KCONFIG_TEST_ALLOWLIST and TEST_KCONFIG_BOARD_BLOCKLIST This will test kconfig modeling on a small subset of apps for all boards that are not on the blocklist. This should automatically test new boards, preventing merging of non-kconfig complete boards.
6e99c75 to
5f7c31f
Compare
Contributor
Author
|
Squashed, removed app limiting, and cleaned up the tput commands. Everything should be good to go. As we have to wait for the CI maybe now would be a good time to auto-merge? |
Contributor
Author
|
Many thanks for the quick reviews, it is nice to get this in before everyone's vacation. |
Contributor
Author
|
Oh shoot, we need an ack ping @kaspar030 @fjmolinas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Introduce the TEST_KCONFIG_TEST_ALLOWLIST and TEST_KCONFIG_BOARD_BLOCKLIST
This will test kconfig modeling on a small subset of apps
for all boards that are not on the blocklist.
This should automatically test new boards, preventing merging
of non-kconfig complete boards.
Testing procedure
CI green and verify that boards are being tested by murdock for the specified apps.
Issues/PRs references
Part of #16875