Skip to content

cc2420: Port cc2420 to netdev.802154#1733

Closed
miri64 wants to merge 9 commits intoRIOT-OS:masterfrom
miri64:netdev-ieee802154
Closed

cc2420: Port cc2420 to netdev.802154#1733
miri64 wants to merge 9 commits intoRIOT-OS:masterfrom
miri64:netdev-ieee802154

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 29, 2014

To test this, run

export BOARD=telosb # or z1, or wsn430-v1_4
SENDER=0 make -C tests/netdev/ all flash && SENDER=1 make -C tests/netdev/ all flash && make -C tests/netdev/ test

Depends on #1492. (it's merged)

* #1680
|\
… …
| |
| * #1448
| |\
* | | #1733
| * | #1732
| | * #1731
| |/
|/
* (master)

Depends on #2163

@miri64 miri64 force-pushed the netdev-ieee802154 branch 2 times, most recently from eff6b49 to 99e70e5 Compare September 29, 2014 13:00
@miri64 miri64 mentioned this pull request Sep 29, 2014
Merged
@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first Area: network Area: Networking labels Sep 29, 2014
@miri64 miri64 added this to the Release NEXT MAJOR milestone Sep 29, 2014
@miri64 miri64 mentioned this pull request Sep 29, 2014
Closed
@miri64 miri64 force-pushed the netdev-ieee802154 branch from 99e70e5 to 3c17e72 Compare October 1, 2014 17:26
@miri64 miri64 mentioned this pull request Oct 1, 2014
Merged
5 tasks
@miri64 miri64 force-pushed the netdev-ieee802154 branch from 3c17e72 to 4a6e33f Compare October 2, 2014 10:32
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 2, 2014

Rebased to master

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 2, 2014
@miri64 miri64 force-pushed the netdev-ieee802154 branch from 4a6e33f to 66d4f99 Compare October 2, 2014 11:16
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 2, 2014
@rousselk
Copy link
Copy Markdown
Contributor

rousselk commented Oct 2, 2014

The code seems OK to me... However, I didn't have time to test. I'll try to handle this next week.

@miri64 miri64 force-pushed the netdev-ieee802154 branch 2 times, most recently from 94108f2 to 56fd960 Compare October 3, 2014 13:14
@miri64 miri64 added Area: drivers Area: Device drivers and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 3, 2014
@miri64 miri64 force-pushed the netdev-ieee802154 branch 4 times, most recently from a6c283b to 1ddbcf3 Compare October 9, 2014 08:50
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 9, 2014

Rebased to current master

This was referenced Oct 9, 2014
Merged
Closed
@miri64 miri64 force-pushed the netdev-ieee802154 branch from 2ab4f76 to 6682923 Compare October 16, 2014 12:54
thomaseichinger
thomaseichinger reviewed Oct 16, 2014
View reviewed changes
drivers/cc2420/cc2420_rx.c Outdated
Copy link
Copy Markdown
Member

@thomaseichinger thomaseichinger Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

802153??

Copy link
Copy Markdown
Member Author

@miri64 miri64 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that happen? oO

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Dec 18, 2014

Seems to work on the Z1.

@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Release 2014.12 Dec 18, 2014
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Dec 18, 2014

Postponed anyway.

@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jan 6, 2015
@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Network Stack Task Force Feb 6, 2015
@OlegHahm OlegHahm added NSTF and removed NSTF labels Feb 6, 2015
@miri64 miri64 modified the milestone: Network Stack Task Force Feb 8, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 8, 2015

Abondened. But memo'ed for future reference, if someone wants to implement it for #2278.

@miri64 miri64 closed this Feb 8, 2015
@miri64 miri64 deleted the netdev-ieee802154 branch February 8, 2015 14:11
@4dahalibut
Copy link
Copy Markdown

4dahalibut commented Jul 13, 2015

I'd like to implement this for #2278 . Could somebody tell me some relevant info that would be good to know for this undertaking? Also it seems like somebody started writing it and then stopped?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 13, 2015

@4dahalibut this issue is deprecated since netdev.802154 does not exist anymore. Please look into ng_netdev and already existing IEEE 802.15.4 drivers (ng_at86rf2xx, xbee, kw2xrf, … descending order of recommendation) for reference.

@4dahalibut
Copy link
Copy Markdown

4dahalibut commented Jul 13, 2015

Okay I meant implementing the cc2420 driver for ng_netdev. Where should I post about that?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 13, 2015

First you should read "How to implement a ng_netdev enabled device". If you have further questions you can ask them on the mailing list. Most people (including me) will be happy to answer your questions there :-). When you have a somewhat complete implementation (you probably can refurbish a lot from the existing implementation at drivers/cc2420) you can open a PR for that, or you open a WIP progress and relabel it as done, when you are in a somewhat stable state ;-).

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jul 13, 2015

ng_netdev will probably be outdated soon. I have a native ethernet and cc110x driver based on netdev2 in the queue. Take a look at https://github.com/kaspar030/RIOT/tree/add_gnrc_netdev2_support for my current WIP.

@4dahalibut
Copy link
Copy Markdown

4dahalibut commented Jul 13, 2015

Wait so netdev2 is another device interface different than the one cc2420 was originally written for, different from the one it was going to be written for and abandoned, and different from ng_netdev?

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jul 13, 2015

Yes. cc2420 for RIOT has as long a history as RIOT itself.

But netdev2 is very similar to ng_netdev.

@4dahalibut
Copy link
Copy Markdown

4dahalibut commented Jul 13, 2015

Is the rest of the ng_* stack going to be integrated into the netdev2 interface?

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jul 13, 2015

Yes. netdev2 is just a low-level network driver interface, very similar to ng_netdev. netdev2 just drops all dependencies to ng_, but in a way that ng still works with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rousselk rousselk

Labels

Area: drivers Area: Device drivers Area: network Area: Networking Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miri64 @rousselk @OlegHahm @4dahalibut @kaspar030 @thomaseichinger