Skip to content

cpu/msp430: add Kconfig#17290

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_kconfig_msp430
Dec 3, 2021
Merged

cpu/msp430: add Kconfig#17290
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_kconfig_msp430

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Nov 29, 2021

Contribution description

These models modules for msp430 CPU. Only z1 is added to .murdock except for the one REMOVE ME commit.

Netdev is not modeled, since there is also discussion on removing cc2420

Testing procedure

  • Green CI
  • Module list between makefile and Kconfig should match.

Issues/PRs references

Part of #16875

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 29, 2021
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: MSP Platform: This PR/issue effects MSP-based platforms labels Nov 29, 2021
@fjmolinas fjmolinas mentioned this pull request Nov 29, 2021
Closed
@github-actions github-actions bot added the Area: boards Area: Board ports label Nov 30, 2021
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 30, 2021
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 1, 2021
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Dec 1, 2021
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 1, 2021
leandrolanzieri
leandrolanzieri reviewed Dec 1, 2021
View reviewed changes
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms labels Dec 1, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 1, 2021

@leandrolanzieri I think your changes have been addressed, if CI passes can I squash?

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Dec 1, 2021

@leandrolanzieri I think your changes have been addressed, if CI passes can I squash?

Sure!

@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 1, 2021

Rebased to solve merge conflicts

@github-actions github-actions bot removed Area: drivers Area: Device drivers Area: tests Area: tests and testing framework Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Platform: MIPS Platform: This PR/issue effects MIPS-based platforms labels Dec 1, 2021
leandrolanzieri
leandrolanzieri reviewed Dec 2, 2021
View reviewed changes
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 2, 2021

@leandrolanzieri murdock is finally green, ok to squash?

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Dec 2, 2021

@leandrolanzieri murdock is finally green, ok to squash?

Sure, please go ahead

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 2, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Dec 2, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 3, 2021

All green @leandrolanzieri!

leandrolanzieri
leandrolanzieri approved these changes Dec 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@leandrolanzieri leandrolanzieri merged commit d7bf363 into RIOT-OS:master Dec 3, 2021
@fjmolinas fjmolinas deleted the pr_kconfig_msp430 branch December 3, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@aabadie aabadie Awaiting requested review from aabadie

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MSP Platform: This PR/issue effects MSP-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

3 participants

@fjmolinas @leandrolanzieri @kaspar030