Skip to content

cpu/qn908x: model kconfig#17277

Merged
fjmolinas merged 5 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/cpu/qn908x/model_kconfig
Dec 1, 2021
Merged

cpu/qn908x: model kconfig#17277
fjmolinas merged 5 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/cpu/qn908x/model_kconfig

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Nov 26, 2021

Contribution description

This models modules for qn908x CPU and the only board that uses it: qn9080dk

Testing procedure

  • Green CI
  • Module list between makefile and Kconfig should match.

Issues/PRs references

Part of #16875

@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 26, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 26, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 26, 2021
Closed
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 26, 2021
fjmolinas
fjmolinas approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, please squash!

@fjmolinas fjmolinas enabled auto-merge November 29, 2021 09:54
benpicco
benpicco reviewed Nov 29, 2021
View reviewed changes
cpu/qn908x/periph/Kconfig Outdated
config MODULE_PERIPH_FLEXCOMM
bool
depends on TEST_KCONFIG
default y if MODULE_PERIPH_UART || MODULE_PERIPH_I2C
Copy link
Copy Markdown
Contributor

@benpicco benpicco Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't SPI also select this?
@iosabi

Copy link
Copy Markdown
Contributor

@iosabi iosabi Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very likely, SPI is a flexcomm.

Copy link
Copy Markdown
Contributor Author

@leandrolanzieri leandrolanzieri Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it, it's not in the Makefile.dep

Copy link
Copy Markdown
Contributor

@iosabi iosabi Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I forgot, thanks!

Copy link
Copy Markdown
Contributor Author

@leandrolanzieri leandrolanzieri Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Nov 29, 2021

Please squash!

@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/qn908x/model_kconfig branch from d521770 to ea247d2 Compare November 29, 2021 12:54
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 30, 2021
@fjmolinas fjmolinas merged commit cb07027 into RIOT-OS:master Dec 1, 2021
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 1, 2021

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/cpu/qn908x/model_kconfig branch December 1, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco left review comments

@fjmolinas fjmolinas fjmolinas approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

+1 more reviewer

@iosabi iosabi iosabi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

5 participants

@leandrolanzieri @benpicco @fjmolinas @iosabi @kaspar030